pspp-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: assertion on Ctrl-C


From: Ben Pfaff
Subject: Re: assertion on Ctrl-C
Date: Mon, 25 Jun 2007 20:38:14 -0700
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.99 (gnu/linux)

John Darrington <address@hidden> writes:

> I've noticed that occasionally when I hit Ctrl-C, the assertion at
> procedure.c:546 fires.
>
> The problem seems to be that the interrupt handler calls
> destroy_dataset while not in the COMMITTED state.

We could fix that in the procedure code.  The question is, should
we?  If we fix the "obvious" problems with asynchronous signals,
I'm sure that we'll just discover that there are numerous more
subtle problems with signals, some of which only occur when PSPP
is compiled with certain optimization flags with some compilers
on some platforms...

I suspect it's better to not clean up so much on Ctrl+C.  Just
delete temporary files (if necessary) and exit.  Doing as little
as possible in a signal handler is Good.

What do you think?
-- 
"The fact is, technical people are better off not looking at patents. If
 you don't know what they cover and where they are, you won't be knowingly
 infringing on them. If somebody sues you, you change the algorithm or you
 just hire a hit-man to whack the stupid git." --Linus Torvalds




reply via email to

[Prev in Thread] Current Thread [Next in Thread]