[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch #6071] Resing/Deleting/Inserting variables in GUI

From: Ben Pfaff
Subject: [patch #6071] Resing/Deleting/Inserting variables in GUI
Date: Tue, 10 Jul 2007 04:02:46 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20061205 Iceweasel/ (Debian-

Follow-up Comment #1, patch #6071 (project pspp):

Is the datasheet.c assertion correct?  I think that the test should be "<="
not "<".

value_cnt_from_width (var_get_width (v)) can be replaced by var_get_value_cnt
(v) in a couple of places.

The procedure for changing the width of a variable in a dictionary in-place
makes me nervous.  It seems to me that it's only appropriate in the
particular case where the data is coming from something like a datasheet,
where the case data is automatically rearranged as the dictionary is
manipulated.  And in that case, I don't understand why just doing
set_var_width as-is and then dict_compact on its dictionary wouldn't have the
same effect.

If we do need a new in-place resizing procedure, then I'd like
dict_pad_values to be a static function.  No need to encourage anything else
to take advantage of it...


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]