[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch #6109] Improvements to sys file reader, writer

From: John Darrington
Subject: [patch #6109] Improvements to sys file reader, writer
Date: Mon, 23 Jul 2007 01:55:49 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20060607 Debian/1.7.12-1.2

Follow-up Comment #1, patch #6109 (project pspp):

I've not actually tried any of these patches.  But here are my comments:

In por-writer-vls.patch, perhaps "255" should be  replaced by something more
meaningfull (maybe MIN_VERY_LONG_STRING - 1)

Regarding the assignment of the display width in sysfile writer, I agree the
current code is bizarre.
I think that a string variable's display width when it is created should be
set to be equal to the format width unless that width exceeds some maximum. 
This should be done in variable.c ; I don't see any need for sysfile-writer
to tamper with this parameter.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]