pspp-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch #6363] rework settings into single struct


From: Ben Pfaff
Subject: [patch #6363] rework settings into single struct
Date: Mon, 07 Jan 2008 00:47:22 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.1) Gecko/20061205 Iceweasel/2.0.0.1 (Debian-2.0.0.1+dfsg-1)

Update of patch #6363 (project pspp):

                  Status:   Ready For Test/Review => Works For Me           

    _______________________________________________________

Follow-up Comment #1:

This looks OK to me.  A few nits:

In init_style, testing whether &styles[type] is NULL makes no sense: it will
always be false (unless styles is NULL and type is 0, but that shouldn't
happen).

Could each line in the_settings have a comment over on the right giving the
name of the corresponding member?  This will make it easer to read the list
and to update it as settings are added, changed, or removed.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?6363>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/





reply via email to

[Prev in Thread] Current Thread [Next in Thread]