[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: PSPP 0.6.1 pre-release

From: John Darrington
Subject: Re: PSPP 0.6.1 pre-release
Date: Sat, 4 Oct 2008 13:18:56 +0800
User-agent: Mutt/1.5.18 (2008-05-17)

On Fri, Oct 03, 2008 at 09:30:35PM -0700, Ben Pfaff wrote:
     Thanks, I pushed the following to pre-0.6.1, which is in rc2.
     Let me know if you see anything amiss:
     commit 65eaf640ddf133276d3ea1b9c0fc263ee6139bdc
     Author: Ben Pfaff <address@hidden>
     Date:   Fri Oct 3 20:53:51 2008 -0700
         Append $(EXEEXT_FOR_BUILD) to output file name when building q2c.
         Thanks to "Michel Boaventura" <address@hidden> for reporting
         this problem and to John Darrington for assisting with the solution.
     diff --git a/src/language/lexer/ 
     index e0efbb6..0ce371a 100644
     --- a/src/language/lexer/
     +++ b/src/language/lexer/
     @@ -17,7 +17,7 @@ EXTRA_DIST += src/language/lexer/q2c.c
        @$(MKDIR_P) `dirname address@hidden
     -  $(CC_FOR_BUILD) $(top_srcdir)/src/language/lexer/q2c.c -o 
     +  $(CC_FOR_BUILD) $(top_srcdir)/src/language/lexer/q2c.c -o 

Just an observation:  I don't think that the "$(top_builddir)/" in the
action of this rule is actually necessary.  On the other hand, it was
there before, and I can't imagine that it does any harm except from a
readability point of view.

PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See or any PGP keyserver for public key.

Attachment: signature.asc
Description: Digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]