[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch #6801] Sign Test

From: Ben Pfaff
Subject: [patch #6801] Sign Test
Date: Wed, 08 Apr 2009 04:40:08 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20061205 Iceweasel/ (Debian-

Follow-up Comment #1, patch #6801 (project pspp):

Looks good.  A few comments:

* In the documentation, could you refer to subcommand names in all-capitals
(e.g. WILCOXON, SIGN).  It's the convention that I've tried to use throughout
the manual; it may not be the best convention, but it's best to be consistent
about it at least, I think.

* In sign.h, it is pretty odd to have some declarations outside the main
#ifndef...#endif block.  Could you move them inside it?

* Also in that header, the "enum mv_class;" forward declaration of an enum is
a GCC extension.  Instead of doing that, could you insert #include


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]