Re: Merge the "charset" branch?

[John Darrington]

One small issue I've just noticed:

 hash = hsh_hash_string (tocode) ^ hsh_hash_string (fromcode);

Since the ^ operator is commutative, won't this create the same hash
for complementary convertors?  It's going to be very common to have,
say, a utf8-to-latin1 convertor and a latin1-to-utf8 convertor
concurrently.

  HMAPX_FOR_EACH_WITH_HASH (converter, node, hash, &map)
    if (!strcmp (tocode, converter->tocode)
        && !strcmp (fromcode, converter->fromcode))
      return converter->conv;

-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://pgp.mit.edu or any PGP keyserver for public key.

signature.asc
Description: Digital signature