[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Leak in casewriter.c

From: John Darrington
Subject: Leak in casewriter.c
Date: Tue, 1 Jun 2010 16:12:13 +0000
User-agent: Mutt/1.5.18 (2008-05-17)

It seems that caseprotos aren't getting destroyed in certain circumstances.

I think this is the correct patch.  Ben do you concurr ?

diff --git a/src/data/casewriter.c b/src/data/casewriter.c
index f7760ec..7631d77 100644
--- a/src/data/casewriter.c
+++ b/src/data/casewriter.c
@@ -99,6 +99,8 @@ casewriter_make_reader (struct casewriter *writer)
   struct casereader *reader = writer->class->convert_to_reader (writer, 
   taint_propagate (writer->taint, casereader_get_taint (reader));
+  caseproto_unref (writer->proto);
   taint_destroy (writer->taint);
   free (writer);
   return reader;

PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See or any PGP keyserver for public key.

Attachment: signature.asc
Description: Digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]