[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [i18n 0/6] Fixes for recode_string().

From: Ben Pfaff
Subject: Re: [i18n 0/6] Fixes for recode_string().
Date: Tue, 21 Sep 2010 22:19:31 -0700
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)

John Darrington <address@hidden> writes:

> On Mon, Sep 20, 2010 at 10:50:20PM -0700, Ben Pfaff wrote:
>      When I was looking at other code tonight, I noticed some problems
>      with the recode_string() function.  This series fixes them up.
> I don't see any problems with any of these patches, although I haven't
> actually tried them.

Thank you, I pushed them.

>      I suspect that the testsuite does not exercise this function all
>      that well, but it does pass with these changes.
> So far as I'm aware, there are no tests whatsoever for this function.
> We should add some and do some coverage analysis too.

OK, I've written a few simple tests.  I'll email them out in a

I didn't do coverage analysis.  I suspect that my tests don't
exercise the logic to enlarge the buffer.
Ben Pfaff

reply via email to

[Prev in Thread] Current Thread [Next in Thread]