pspp-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [warnings 2/7] recode: Fix a warning in recode_trns_proc().


From: Ben Pfaff
Subject: Re: [warnings 2/7] recode: Fix a warning in recode_trns_proc().
Date: Thu, 23 Sep 2010 20:07:57 -0700
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)

Ben Pfaff <address@hidden> writes:

> John Darrington <address@hidden> writes:
>
>> On Fri, Sep 17, 2010 at 09:36:27PM -0700, Ben Pfaff wrote:
>>      case_str_rw() returns uint8_t * but it was being assigned to a char *.
>>      Changing the type of the variable fixes the problem.
>>
>> The real problem here is the call to memcpy just a few lines down.
>> memcpy is as bad (worse?) than a cast, because it uses void * so
>> avoids typechecking.  This memcpy should be doing some recoding.
>
> OK, how about the following then?
>
> Thanks,
>
> Ben.
>
> --8<--------------------------cut here-------------------------->8--
>
> From: Ben Pfaff <address@hidden>
> Date: Sun, 19 Sep 2010 20:55:46 -0700
> Subject: [PATCH] RECODE: Suppress warning about conversion using 
> CHAR_CAST_BUG.

Having given this 3 days, I pushed this out.
-- 
Ben Pfaff 
http://benpfaff.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]