[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: datasets 17/18] gui: Add ellipsis to menu items that require further

From: Harry Thijssen
Subject: Re: datasets 17/18] gui: Add ellipsis to menu items that require further input.
Date: Sun, 1 May 2011 16:17:11 +0200

This patch looks good to me but has a timing issue.

At the moment this patch is committed a lot of translations in the GUI become fuzzy. At that moment the translators can´t update it as there is an old POT file in the translation project.

I would suggest to hold this patch until a new version of the .POT file is uploaded to the translation project so translators can translate the new strings for incorporation.

An alternative would  be to upload the .POT file as version 0.7.7-post1 to the translation project.

Have fun

Date: Sat, 30 Apr 2011 22:36:45 -0700
From: Ben Pfaff
To: address@hidden
Subject: [datasets 17/18] gui: Add ellipsis to menu items that require
       further input.

The GNOME Human Interface Guidelines say:

   Label the menu item with a trailing ellipsis ("...") only if
   the command requires further input from the user before it
   can be performed. Do not add an ellipsis to items that only
   present a confirmation dialog (such as Delete), or that do
   not require further input (such as Properties, Preferences or

Most PSPPIRE menu items fit this description, so they should have
trailing ellipses, which this commit adds.
 src/ui/gui/data-editor.ui   |   62 +++++++++++++++++++++++--------------------
 src/ui/gui/output-viewer.ui |    3 +-
 src/ui/gui/syntax-editor.ui |    2 +
 3 files changed, 37 insertions(+), 30 deletions(-)

diff --git a/src/ui/gui/data-editor.ui b/src/ui/gui/data-editor.ui
index 498f3fc..e64334a 100644
--- a/src/ui/gui/data-editor.ui
+++ b/src/ui/gui/data-editor.ui
@@ -45,12 +45,13 @@
          <object class="GtkAction" id="file_open">
            <property name="stock-id">gtk-open</property>
            <property name="name">file_open</property>
+            <property name="label" translatable="yes">_Open...</property>
          <object class="GtkAction" id="file_import-text">
            <property name="name">file_import-text</property>
-            <property name="label" translatable="yes">_Import Delimited Text Data</property>
+            <property name="label" translatable="yes">_Import Delimited Text Data...</property>
           <property name="stock-id">gtk-convert</property>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]