pspp-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug33254 1/6] encoding-guesser: New function encoding_guess_whole_f


From: Ben Pfaff
Subject: Re: [bug33254 1/6] encoding-guesser: New function encoding_guess_whole_file().
Date: Thu, 12 May 2011 21:06:25 -0700
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)

John Darrington <address@hidden> writes:

> These patches look good to me. However it's a shame that
> latin-1 etc. cannot be detected.  

It's true.  I think I'll save that for a bit later, because it's
a general issue with the encoding guesser.

> The text "Character Encoding:" is juxtaposed hard against the
> combo box, making it look a bit awkward.  Either the hbox needs
> padding or just append a space to the string.

I added a space.

> The "(Auto)" in "Automatically Detect (Auto)" seems somewhat
> redundant to me.

It's true.  I removed the (Auto) part.
-- 
Ben Pfaff 
http://benpfaff.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]