pspp-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Type 3 sums of squares algorithm


From: John Darrington
Subject: Type 3 sums of squares algorithm
Date: Sat, 9 Jul 2011 08:21:10 +0000
User-agent: Mutt/1.5.18 (2008-05-17)

In the function get_ssq, there is the code

      for (i = 1; i < covariance_dim (cov); i++)
        {
          if (vars[i] == cmd->design_vars[k])
            {
              dropped[n_dropped++] = i;
            }
        }

If I understand it correctly, this loop starts from i = 1 rather
than i = 0, because we're interested only in the explanatory variables,
not the dependent ones.

That being the case, we should change this to
      for (i = cmd->n_dep_vars; i < covariance_dim (cov); i++)

So that it'll work for multivariate analysis sometime in the future?


-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://pgp.mit.edu or any PGP keyserver for public key.

Attachment: signature.asc
Description: Digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]