[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/13] gui: Add undocumented --measure-startup option.
From: |
John Darrington |
Subject: |
Re: [PATCH 03/13] gui: Add undocumented --measure-startup option. |
Date: |
Wed, 18 Apr 2012 06:13:49 +0000 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Mon, Apr 16, 2012 at 08:52:09PM -0700, Ben Pfaff wrote:
This is useful for testing the effects of code changes upon the
time required to start PSPPIRE.
---
src/ui/gui/main.c | 37 ++++++++++++++++++++++++++++++++++---
1 files changed, 34 insertions(+), 3 deletions(-)
diff --git a/src/ui/gui/main.c b/src/ui/gui/main.c
index bb8f19d..eea71f8 100644
--- a/src/ui/gui/main.c
+++ b/src/ui/gui/main.c
@@ -196,9 +216,17 @@ static gboolean
run_inner_loop (gpointer data)
{
struct initialisation_parameters *ip = data;
+ GSource *source;
+ guint id;
+
initialize (ip->data_file);
- g_timeout_add (500, hide_splash_window, ip->splash_window);
+ source = g_idle_source_new ();
+
+ g_source_set_priority (source, G_PRIORITY_LOW);
+ g_source_set_callback (source, hide_splash_window, ip->splash_window,
NULL);
+ id = g_source_attach (source, NULL);
+ g_source_unref (source);
I haven't tried this patch, but I'm concerned that it seems to change then
behaviour
of the splash window. The way it was designed was to appear as soon as it can,
and
stay on the screen for as long as it takes to run the initialize
function, plus half a second. This change seems to make it disappear
immediately
after initialize returns, which is fine on a slow machine, but on a fast one,
could make it flash too quick to see, which might alarm users.
--
PGP Public key ID: 1024D/2DE827B3
fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3
See http://keys.gnupg.net or any PGP keyserver for public key.
signature.asc
Description: Digital signature
- [PATCH 00/13] second batch of psppsheet changes, Ben Pfaff, 2012/04/16
- [PATCH 01/13] psppire-dict: g_return_if_fail for idx in psppire_dict_get_variable()., Ben Pfaff, 2012/04/16
- Re: [PATCH 01/13] psppire-dict: g_return_if_fail for idx in psppire_dict_get_variable()., John Darrington, 2012/04/17
- Re: [PATCH 01/13] psppire-dict: g_return_if_fail for idx in psppire_dict_get_variable()., Ben Pfaff, 2012/04/18
- Re: [PATCH 01/13] psppire-dict: g_return_if_fail for idx in psppire_dict_get_variable()., John Darrington, 2012/04/18
- Re: [PATCH 01/13] psppire-dict: g_return_if_fail for idx in psppire_dict_get_variable()., Ben Pfaff, 2012/04/19
- Re: [PATCH 01/13] psppire-dict: g_return_if_fail for idx in psppire_dict_get_variable()., Ben Pfaff, 2012/04/21
- Re: [PATCH 01/13] psppire-dict: g_return_if_fail for idx in psppire_dict_get_variable()., John Darrington, 2012/04/21
[PATCH 02/13] gui: Use canonical names for signals., Ben Pfaff, 2012/04/16
[PATCH 03/13] gui: Add undocumented --measure-startup option., Ben Pfaff, 2012/04/16
- Re: [PATCH 03/13] gui: Add undocumented --measure-startup option.,
John Darrington <=
[PATCH 04/13] gui: Call g_thread_init() earlier., Ben Pfaff, 2012/04/16
[PATCH 05/13] format: New functions fmt_change_width(), fmt_change_decimals()., Ben Pfaff, 2012/04/16
[PATCH 07/13] format: Fix typo in comment., Ben Pfaff, 2012/04/16
[PATCH 08/13] helper: New function value_to_text__()., Ben Pfaff, 2012/04/16
[PATCH 09/13] value-labels: New function val_labs_find_value()., Ben Pfaff, 2012/04/16
[PATCH 06/13] format: Introduce a new type "enum fmt_use"., Ben Pfaff, 2012/04/16
[PATCH 10/13] abt: Drop child parameters from 'reaugment' function., Ben Pfaff, 2012/04/16
[PATCH 11/13] abt: New function abt_is_empty()., Ben Pfaff, 2012/04/16
[PATCH 12/13] range-set: Rename "insert" function "set1", "delete" to "set0"., Ben Pfaff, 2012/04/16