[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 06/17] pspp-sheet-view-column: Add support for tooltips on co
From: |
Ben Pfaff |
Subject: |
Re: [PATCH 06/17] pspp-sheet-view-column: Add support for tooltips on columns. |
Date: |
Mon, 23 Apr 2012 22:41:56 -0700 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) |
John Darrington <address@hidden> writes:
> On Sun, Apr 22, 2012 at 11:12:24AM -0700, Ben Pfaff wrote:
>
> + tree_column_signals[QUERY_TOOLTIP] =
> + g_signal_new (I_("query-tooltip"),
>
> What does the I_ do here? Is this a convention we should be using for
> signals
> in other parts of the code?
I copied this pattern from GTK+ code.
./gtk/gtkintl.h has:
#define I_(string) g_intern_static_string (string)
I guess it's probably intended as a small optimization. But,
looking at g_signal_new, I don't think it's really good for
anything.
I'll remove these from the whole patch series.
- [PATCH 00/17] Implement PsppSheetView, Ben Pfaff, 2012/04/22
- [PATCH 04/17] pspp-sheet-view: Fix visual artifacts for sheet views > 65535 pixels wide., Ben Pfaff, 2012/04/22
- [PATCH 03/17] pspp-sheet-view: Improve scrolling performance., Ben Pfaff, 2012/04/22
- [PATCH 05/17] pspp-sheet-view: Fix rendering moving cursor left or right with keyboard., Ben Pfaff, 2012/04/22
- [PATCH 06/17] pspp-sheet-view-column: Add support for tooltips on columns., Ben Pfaff, 2012/04/22
- [PATCH 07/17] pspp-sheet-view: Edit cells on the first click by default., Ben Pfaff, 2012/04/22
- [PATCH 09/17] pspp-sheet-view: Start editing upon button release, not press., Ben Pfaff, 2012/04/22
- [PATCH 10/17] pspp-sheet-view: Add "special-cells" property to speed drawing many columns., Ben Pfaff, 2012/04/22
- [PATCH 13/17] pspp-sheet-view: Improve look of sheet when there are few columns., Ben Pfaff, 2012/04/22
- [PATCH 11/17] pspp-widget-facade: New code to measure and render some GTK+ widgets., Ben Pfaff, 2012/04/22
- [PATCH 14/17] pspp-sheet-view: Make pspp_sheet_view_stop_editing() public., Ben Pfaff, 2012/04/22
- [PATCH 08/17] pspp-sheet-view: Support rectangular selection, column popup menus., Ben Pfaff, 2012/04/22