[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 0/4] bug fixes for master
From: |
Ben Pfaff |
Subject: |
[PATCH 0/4] bug fixes for master |
Date: |
Sat, 7 Jul 2012 23:49:12 -0700 |
Here is a series of bug fixes for master in response to John's
bug report:
> I noticed the following problem using the psppsheet branch as of
> d4ae90b2fe74d2d1427afad35d32c9e5584211ed
>
> 1. Prepare a .sav file (call it x.sav) with some data.
>
> 2. Start psppire
>
> 3. File | Open and load x.sav (dataset1)
>
> 4. File | New | Data (a new data window will appear: dataset2)
>
> 5. Using the window manager close the window for dataset1
>
> 6. In dataset2: File | Open and load x.sav
>
> A lot of Gtk-Criticals appear and the program quickly crashes.
I've committed the second patch to the psppsheet branch already.
Once all these go in, I'll merge them to the psppsheet branch.
Review is appreciated.
Thanks,
Ben.
Ben Pfaff (4):
gui: Fix Glib-GObject-WARNING when closing the active dataset.
psppire-dict: Make PsppireDict not own its "struct dictionary".
psppire-dict: Unset dict callback on dispose.
psppire-data-window: Delete dataset when closing window.
src/data/session.c | 17 ++++++++++++++++-
src/data/session.h | 4 +++-
src/ui/gui/executor.c | 18 +++++++++++++++++-
src/ui/gui/psppire-data-window.c | 17 +++++++++++++----
src/ui/gui/psppire-dict.c | 10 +++++-----
src/ui/gui/text-data-import-dialog.c | 2 +-
6 files changed, 55 insertions(+), 13 deletions(-)
--
1.7.2.5