pspp-dev
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] psppire-window-base: Avoid memory leak in get_window_id().

From: John Darrington
Subject: Re: [PATCH] psppire-window-base: Avoid memory leak in get_window_id().
Date: Mon, 9 Jul 2012 08:52:24 +0000
User-agent: Mutt/1.5.18 (2008-05-17) 
On Sun, Jul 08, 2012 at 11:45:48PM -0700, Ben Pfaff wrote:
     g_object_get() returns a string copy, so the caller has to free it.
     
     Found by valgrind.
     ---
     Review appreciated.

It seems rather pointless to make a deep copy of this string, only to 
immediately free it.
So if g_object_get insists on copying, then I suggest we just use 
gtk_widget_get_name which 
does not.

J'
     

-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://keys.gnupg.net or any PGP keyserver for public key.

Attachment: signature.asc
Description: Digital signature

reply via email to
[Prev in Thread] Current Thread [Next in Thread]