Re: [PATCH 0/2] var-type-dialog fix and cleanup

[John Darrington]

At a first glance, these look fine.

I haven't tested them.

On Fri, Jul 13, 2012 at 12:00:22AM -0700, Ben Pfaff wrote:
     I'm looking over the var-type-dialog code in response to John's
     earlier bug report.  I see some problems.  Here is one bug fix
     and one cleanup.  I plan to do others, but this is all for tonight.
     
     Comments?
     
     Thanks,
     
     Ben.
     
     Ben Pfaff (2):
       var-type-dialog: Avoid static variables.
       var-type-dialog: Move UI into separate .ui file.
     
      src/ui/gui/automake.mk          |    3 +-
      src/ui/gui/var-sheet-dialogs.ui |  413 
--------------------------------------
      src/ui/gui/var-type-dialog.c    |   28 ++--
      src/ui/gui/var-type-dialog.ui   |  418 
+++++++++++++++++++++++++++++++++++++++
      4 files changed, 433 insertions(+), 429 deletions(-)
      create mode 100644 src/ui/gui/var-type-dialog.ui
     
     -- 
     1.7.2.5
     
     
     _______________________________________________
     pspp-dev mailing list
     address@hidden
     https://lists.gnu.org/mailman/listinfo/pspp-dev

-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://keys.gnupg.net or any PGP keyserver for public key.

signature.asc
Description: Digital signature