[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: GCC bug workaround
From: |
Ben Pfaff |
Subject: |
Re: GCC bug workaround |
Date: |
Sun, 31 Mar 2013 20:16:36 -0700 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Sun, Mar 31, 2013 at 08:29:35PM +0200, John Darrington wrote:
> I have noticed a really wierd problem, which I think is
> a bug in gcc version 4.4.5
>
> When compiled with -O2 tests [185, 189] (the ODS reader tests) fail.
>
> Investigation shows that the stack is corrupt on return from
> the function casereader_count_cases__ and the program counter
> returns to the wrong address and crashes.
>
> It seems to be a rather wierd bug.
>
> The following patch seems to workaround the symptoms.
The patch seems reasonable to me as a GCC bug workaround. It would be a
good idea to add the explanation above as a comment in the code (and the
commit log).
> Maybe someone can check this doesn't happen with later compilers.
It doesn't happen with GCC 4.7.2 (as we discussed on IRC).