Re: psppsheet ready for merge?

[John Darrington]

On Fri, Apr 26, 2013 at 08:14:19AM -0700, Ben Pfaff wrote:
     Do you think that the psppsheet branch is ready to merge?  Here is my
     current to-do list.  I am not sure that any of these items is important
     enough to delay merging
     
I found a couple more issues which I think should be fixed before merging:

1.  Open a small dataset (one with few variables/cases - not enough to fill the 
window).
    Then click Window | Split - the two right hand panes are blank.

2.  There is a diagnostic message on stdout "owns_primary_selection=0 
should_own=0"

3.  Open a dataset (DataSet1).
    Open a second dataset (DataSet2).
    Close DataSet1
    In Dataset2, select a region of cells. and click Edit|Copy
    The following GtkCriticals are evident:

  ** (lt-psppire:5235): CRITICAL **: Object `edit_paste' could not be found
  (lt-psppire:5235): Gtk-CRITICAL **: gtk_action_set_sensitive: assertion 
`GTK_IS_ACTION (action)' failed
  (lt-psppire:5235): Gtk-CRITICAL **: gtk_builder_get_object: assertion 
`GTK_IS_BUILDER (builder)' failed

    On a couple of occasions I witnessed a crash doing this too, but I can't 
seem to make that happen
    on demand.  However here is the backtrace from one of them:

gdb) bt
#0  0xb716d18f in IA__gtk_builder_get_object (builder=0x90b1028, 
    name=0x80e6ef1 "edit_paste")
    at 
/build/buildd-gtk+2.0_2.20.1-2-i386-TNeM25/gtk+2.0-2.20.1/gtk/gtkbuilder.c:883
#1  0x080929db in get_object_assert (builder=0x90b1028, 
    name=0x80e6ef1 "edit_paste", type=139081536)
    at /home/john/pspp-sheet/src/ui/gui/builder-wrapper.c:63
#2  0x08092a9c in get_action_assert (builder=0x90b1028, 
    name=0x80e6ef1 "edit_paste")
    at /home/john/pspp-sheet/src/ui/gui/builder-wrapper.c:80
#3  0x080a472f in on_owner_change (clip=0x84dc338, event=0x8fd7d08, 
    data=0x8561608)
    at /home/john/pspp-sheet/src/ui/gui/psppire-data-sheet.c:2496
#4  0xb6dd0318 in IA__g_cclosure_marshal_VOID__BOXED (closure=0x90ff6b8, 
    return_value=0x0, n_param_values=2, param_values=0x88c5850, 
    invocation_hint=0xbfb0cc70, marshal_data=0x80a469c)
    at 
/build/buildd-glib2.0_2.24.2-1-i386-AScyie/glib2.0-2.24.2/gobject/gmarshal.c:566
#5  0xb6dc313a in IA__g_closure_invoke (closure=0x90ff6b8, return_value=0x0, 
    n_param_values=2, param_values=0x88c5850, invocation_hint=0xbfb0cc70)
    at 
/build/buildd-glib2.0_2.24.2-1-i386-AScyie/glib2.0-2.24.2/gobject/gclosure.c:767
#6  0xb6dd961d in signal_emit_unlocked_R (node=<value optimized out>, 
    detail=<value optimized out>, instance=0x84dc338, emission_return=0x0, 
    instance_and_params=0x88c5850)
    at 
/build/buildd-glib2.0_2.24.2-1-i386-AScyie/glib2.0-2.24.2/gobject/gsignal.c:3248
#7  0xb6ddabfc in IA__g_signal_emit_valist (instance=0x84dc338, signal_id=291, 
    detail=0, var_args=0xbfb0ce40 "")
    at 
/build/buildd-glib2.0_2.24.2-1-i386-AScyie/glib2.0-2.24.2/gobject/gsignal.c:2981
#8  0xb6ddb076 in IA__g_signal_emit (instance=0x84dc338, signal_id=291, 
    detail=0)
    at 
/build/buildd-glib2.0_2.24.2-1-i386-AScyie/glib2.0-2.24.2/gobject/gsignal.c:3038
#9  0xb737847e in _gtk_clipboard_handle_event (event=0x8fd7d08)
    at 
/build/buildd-gtk+2.0_2.20.1-2-i386-TNeM25/gtk+2.0-2.20.1/gtk/gtkclipboard.c:1915
#10 0xb722992d in IA__gtk_main_do_event (event=0x8fd7d08)
    at 
/build/buildd-gtk+2.0_2.20.1-2-i386-TNeM25/gtk+2.0-2.20.1/gtk/gtkmain.c:1468
#11 0xb70b2dda in gdk_event_dispatch (source=0x8494438, callback=0, 
    user_data=0x0)
    at 
/build/buildd-gtk+2.0_2.20.1-2-i386-TNeM25/gtk+2.0-2.20.1/gdk/x11/gdkevents-x11.c:2372
#12 0xb6d17305 in g_main_dispatch (context=0x8494480)
    at 
/build/buildd-glib2.0_2.24.2-1-i386-AScyie/glib2.0-2.24.2/glib/gmain.c:1960
#13 IA__g_main_context_dispatch (context=0x8494480)
    at 
/build/buildd-glib2.0_2.24.2-1-i386-AScyie/glib2.0-2.24.2/glib/gmain.c:2513
#14 0xb6d1afe8 in g_main_context_iterate (context=0x8494480, 
    block=<value optimized out>, dispatch=1, self=0x846d028)
    at 
/build/buildd-glib2.0_2.24.2-1-i386-AScyie/glib2.0-2.24.2/glib/gmain.c:2591
#15 0xb6d1b527 in IA__g_main_loop_run (loop=0x8618d90)
    at 
/build/buildd-glib2.0_2.24.2-1-i386-AScyie/glib2.0-2.24.2/glib/gmain.c:2799
#16 0xb7229e19 in IA__gtk_main ()
    at 
/build/buildd-gtk+2.0_2.20.1-2-i386-TNeM25/gtk+2.0-2.20.1/gtk/gtkmain.c:1219
#17 0x08099c1c in run_inner_loop (data=0xbfb0d150)
    at /home/john/pspp-sheet/src/ui/gui/main.c:233
#18 0xb7229f81 in gtk_quit_invoke_function ()
    at 
/build/buildd-gtk+2.0_2.20.1-2-i386-TNeM25/gtk+2.0-2.20.1/gtk/gtkmain.c:2339
#19 IA__gtk_main ()
    at 
/build/buildd-gtk+2.0_2.20.1-2-i386-TNeM25/gtk+2.0-2.20.1/gtk/gtkmain.c:1238
#20 0x08099e8c in main (argc=1, argv=0xbfb0d214)
    at /home/john/pspp-sheet/src/ui/gui/main.c:338
 

-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://keys.gnupg.net or any PGP keyserver for public key.

signature.asc
Description: Digital signature