Re: PSPP 0.8.2 soon

[Ben Pfaff]

Another update:

jmd: The offending part seems to be in libpspp-core rather than pspp-convert
blp: cmac-aes256 maybe?
blp: although that has a test of its own
jmd: Do we run it?
blp: I thought so.
blp: You can run test-cmac-aes256 by hand, if not.
jmd: Where is it?
blp: tests/libpspp/test-cmac-aes256?
blp: It should be getting built by "make check" or "make check-programs".
blp: Oh, it's named cmac-aes256-test
jmd: It prints nothing and returns 0
blp: That's success, then.
blp: You'd get an abort if it failed.
blp: Must be something else, then.
jmd: rijndael-alg-fst ?
blp: That's a possibility, but cmac-aes256 uses it, so it's got to
basically work.
blp: You want to try valgrind?
jmd: valgrind is clean.
blp: hmm
blp: I might have to add some more tests or suggest some more ideas to
try tonight, after I get home.
blp: Are you on x86 or x86-64?
blp: I generally test on x86.
jmd: x86
blp: Hmm.
blp: GCC version?
blp: I think I have 4.7.x
jmd: gcc (Debian 4.7.2-5) 4.7.2
blp: OK, probably same as me, I use Debian too.
blp: Maybe I can just try to reproduce it with -O0 myself.
jmd: I think the culprit is src/libpspp/cmac-aes256.c
blp: OK.
blp: Any more specific hint?
blp: Or I can just try to chase it down on my own, with -O0, tonight.
jmd: Nothing more specific. Sorry.
blp: OK.

On Mon, Dec 23, 2013 at 1:05 PM, Ben Pfaff <address@hidden> wrote:
> Update from IRC:
>
> jmd: I think it depends on CFLAGS
> blp: Oh? How so?
> jmd: If I run ./configure without any CFLAGS= argument it works.
> jmd: If I pass CFLAGS='-O0 -g' it cannot decrypt.
> blp: That's really curious.
> blp: The default is '-O2 -g' so I guess somehow there's an
> optimization sensitivity in there.
>
> On Mon, Dec 23, 2013 at 11:34 AM, John Darrington
> <address@hidden> wrote:
>> On Mon, Dec 23, 2013 at 09:03:47AM -0800, Ben Pfaff wrote:
>>      On Mon, Dec 23, 2013 at 12:32:35PM +0100, John Darrington wrote:
>>      > On Sat, Dec 21, 2013 at 11:49:32PM -0800, Ben Pfaff wrote:
>>      >      I'd like to release PSPP 0.8.2 in a week or two.  Please report 
>> any
>>      >      regressions that you have noticed, so that we can fix them 
>> before the
>>      >      release.
>>      >
>>      > I notice one small problem:
>>      >
>>      > In guix, test 144 fails with this error:
>>      >
>>      > +An error occurred while opening `../.././data/hotel-encrypted.sav': 
>> No such file or directory.
>>      > +An error occurred while opening `../.././data/hotel-encrypted.sav': 
>> No such file or directory.
>>      > ./sys-file-encryption.at:5: exit code was 1, expected 0
>>      > 144. sys-file-encryption.at:3:  FAILED (sys-file-encryption.at:5)
>>      >
>>      >
>>      >
>>      > Let's fix this before we release.
>>
>>      Oops, sorry.  I checked in a fix for this and a new Makefile rule to
>>      make it harder to screw this up in the future.
>>
>> I get a different error now:
>>
>> +pspp-convert: sorry, wrong password
>> /home/john/pspp-master/tests/sys-file-encryption.at:5: exit code was 1, 
>> expected 0
>> 144. sys-file-encryption.at:3:  FAILED (sys-file-encryption.at:5)
>>
>> J'
>>
>> --
>> PGP Public key ID: 1024D/2DE827B3
>> fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
>> See http://sks-keyservers.net or any PGP keyserver for public key.
>>