Re: Output format for p-values

[John Darrington]

On Thu, Apr 24, 2014 at 08:58:20PM -0700, Ben Pfaff wrote:
     On Tue, Apr 22, 2014 at 08:40:22AM +0200, John Darrington wrote:
     > Perhaps we could change tab_double and tab_value to take a "reported 
value class", say
     > 
     > enum reported_value_class {
     >  WEIGHT,
     >  INTEGER,
     >  P_VALUE,
     >  OTHER
     > };
     > 
     > and then have a map which associates each class with a function to 
determine how it should
     > be displayed.  We would then need to provide a means for the user to 
change the mapping 
     > as he desires.
     > 
     > Such a solution should be regarded as intermediate, until we get a 
better abstraction of
     > our data output, but might be solve the immediate problem without too 
much effort.
     
     I think that's a fine way to start.  If you have time and inclination
     to work on it, then it makes sense to me.

Here's a first patch.  It adds the report_class parameter to tab_double and 
updates all callers.
It then provides a map from classes to format.  I've set the format for 
p-values to 5.3
I have also updated all the affected tests.  I have also removed tab_fixed 
since it had few callers
and did not provide much benefit over tab_double.

The limitation at the moment is that there is no way to override the 5.3 choice 
if you want more than
three decimal places.  That needs to come later.

If there are no objections to this patch, I will push it and think about how to 
proceed.

J'


-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.

0001-Added-result_class-parameter-to-tab_double-and-updat.patch
Description: Text Data

signature.asc
Description: Digital signature