Re: PSPP resize view bug.

[John Darrington]

On Sun, May 25, 2014 at 03:38:44PM -0700, Ben Pfaff wrote:
     On Sun, May 25, 2014 at 12:20 PM, Ben Pfaff <address@hidden> wrote:
     > On Sun, May 25, 2014 at 12:16 PM, Ben Pfaff <address@hidden> wrote:
     >> On Fri, May 16, 2014 at 1:38 PM, John Darrington
     >> <address@hidden> wrote:
     >>> Here is a file which provokes the problem.  Load it into the gui and 
resize the second column in the data view.
     >>>
     >>> Also attached a patch which avoids the problem.
     >>
     >>
     >> Thanks.  I see the hang, but the patch doesn't fix it for me.
     >> I'm taking a closer look.
     >
     > I take it back--the patch does fix it.  Now I am studying it to make
     > sure that I agree that it is correct.

I didn't for one moment think that my patch was correct (I said "avoids" not 
"fixes").
     
     I came up with a very simple change that fixed the problem for me.
     It seemed to be "obviously correct", so I applied it.  Do you think that
     we should also apply some part of the patch that you came up with?

Like you say.  Your patch is obviously correct and simple.

The patch I mailed you was probably a red-herring.   The fact that
PsppireSheetViewColumn has a "dirty" member which is set but never read nor 
reset 
suggests that this part of the code needs a closer look.    It is however
an issue most likely orthogonal to the bug that was reported.

J'



-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.

signature.asc
Description: Digital signature