Re: Buffer overflow in segmenter test ?

[Ben Pfaff]

I pushed fixes for everything reported by Address Sanitizer, including leaks.

On Fri, Oct 8, 2021 at 11:25 PM Ben Pfaff <blp@cs.stanford.edu> wrote:
>
> Thanks, I see those now (along with a number of leaks in macro code).
> I think I should be able to fix them all over the weekend.
>
> (I'm having fun working on the MATRIX procedure, currently writing
> documentation.)
>
> On Fri, Oct 8, 2021 at 10:19 PM John Darrington
> <john@darrington.wattle.id.au> wrote:
> >
> > Tests 570 and 572 are failing when compiled with -fsanitize=address :
> >
> >
> > +READ of size 1 at 0x602000000052 thread T0
> > +    #0 0x409844 in segmenter_parse_mid_command__ 
> > /home/jdarrington/PSPP/pspp-master/src/language/lexer/segment.c:946
> > +    #1 0x40e032 in segmenter_push 
> > /home/jdarrington/PSPP/pspp-master/src/language/lexer/segment.c:1931
> > +    #2 0x40eb93 in check_segmentation 
> > /home/jdarrington/PSPP/pspp-master/tests/language/lexer/segment-test.c:147
> > +    #3 0x40e84c in main 
> > /home/jdarrington/PSPP/pspp-master/tests/language/lexer/segment-test.c:99
> > +    #4 0x7fc50a2dfd09 in __libc_start_main ../csu/libc-start.c:308
> > +    #5 0x4036e9 in _start 
> > (/Scratch/jdarrington/pspp-master-sanitize/tests/language/lexer/segment-test+0x4036e9)
> > +
> > +0x602000000052 is located 0 bytes to the right of 2-byte region 
> > [0x602000000050,0x602000000052)
> > +allocated by thread T0 here:
> > +    #0 0x7fc50a723e8f in __interceptor_malloc 
> > /home/jdarrington/SRC/gcc-10.2.0/libsanitizer/asan/asan_malloc_linux.cpp:145
> > +    #1 0x44036d in xmalloc 
> > /home/jdarrington/PSPP/pspp-master/gl/xmalloc.c:53
> > +    #2 0x44049f in xmemdup 
> > /home/jdarrington/PSPP/pspp-master/gl/xmalloc.c:124
> > +    #3 0x40e830 in main 
> > /home/jdarrington/PSPP/pspp-master/tests/language/lexer/segment-test.c:98
> > +    #4 0x7fc50a2dfd09 in __libc_start_main ../csu/libc-start.c:308
> >
> > J'
> >