[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 06/25] hw/timer/cmsdk-apb-timer: Rename CMSDKAPBTIMER struct
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 06/25] hw/timer/cmsdk-apb-timer: Rename CMSDKAPBTIMER struct to CMSDKAPBTimer |
Date: |
Thu, 21 Jan 2021 21:21:03 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 1/21/21 8:06 PM, Peter Maydell wrote:
> The state struct for the CMSDK APB timer device doesn't follow our
> usual naming convention of camelcase -- "CMSDK" and "APB" are both
> acronyms, but "TIMER" is not so should not be all-uppercase.
> Globally rename the struct to "CMSDKAPBTimer" (bringing it into line
> with CMSDKAPBWatchdog and CMSDKAPBDualTimer; CMSDKAPBUART remains
> as-is because "UART" is an acronym).
>
> Commit created with:
> perl -p -i -e 's/CMSDKAPBTIMER/CMSDKAPBTimer/g' hw/timer/cmsdk-apb-timer.c
> include/hw/arm/armsse.h include/hw/timer/cmsdk-apb-timer.h
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> include/hw/arm/armsse.h | 6 +++---
> include/hw/timer/cmsdk-apb-timer.h | 4 ++--
> hw/timer/cmsdk-apb-timer.c | 28 ++++++++++++++--------------
> 3 files changed, 19 insertions(+), 19 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- [PATCH 07/25] hw/timer/cmsdk-apb-timer: Add Clock input, (continued)
- [PATCH 07/25] hw/timer/cmsdk-apb-timer: Add Clock input, Peter Maydell, 2021/01/21
- [PATCH 13/25] hw/arm/mps2: Create and connect SYSCLK Clock, Peter Maydell, 2021/01/21
- [PATCH 14/25] hw/arm/mps2-tz: Create and connect ARMSSE Clocks, Peter Maydell, 2021/01/21
- [PATCH 06/25] hw/timer/cmsdk-apb-timer: Rename CMSDKAPBTIMER struct to CMSDKAPBTimer, Peter Maydell, 2021/01/21
- [PATCH 15/25] hw/arm/musca: Create and connect ARMSSE Clocks, Peter Maydell, 2021/01/21
- [PATCH 17/25] hw/arm/stellaris: Create Clock input for watchdog, Peter Maydell, 2021/01/21
- [PATCH 18/25] hw/timer/cmsdk-apb-timer: Convert to use Clock input, Peter Maydell, 2021/01/21