qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 0/4] hw/i2c: Adds pca954x i2c mux switch device


From: Corey Minyard
Subject: Re: [PATCH v4 0/4] hw/i2c: Adds pca954x i2c mux switch device
Date: Thu, 15 Apr 2021 07:12:57 -0500

On Mon, Apr 12, 2021 at 12:45:18PM -0700, Patrick Venture wrote:
> The i2c mux device pca954x implements two devices:
>  - the pca9546 and pca9548.

This looks good, I have pulled it into my queue.  6.0 is about to be
released, I'll try to remember to request a pull after that.

Thanks,

-corey

> 
> v4:
>  - Fixed up bug where the i2c_scan_bus wasn't parameterizing the
>  current_devs list.
>  - Minor consistency changes in the i2c mux pca954x.
> 
> v3:
>  - fixup comment with missing end parenthesis.
>  - removed superfluous object cast.
> 
> v2:
>  - the core i2c bus now calls a match method on each i2c child, which
>  by default will only check for a match against itself.
>  - the pca954x device overrides the i2c device match method to search
>  the children for each of its buses that are active.
>  - the pca954x device now owns an i2c bus for each channel, allowing
>  the normal device model to attach devices to the channels.
> 
> Patrick Venture (4):
>   hw/i2c: name I2CNode list in I2CBus
>   hw/i2c: add match method for device search
>   hw/i2c: move search to i2c_scan_bus method
>   hw/i2c: add pca954x i2c-mux switch
> 
>  MAINTAINERS                      |   6 +
>  hw/i2c/Kconfig                   |   4 +
>  hw/i2c/core.c                    |  55 ++++--
>  hw/i2c/i2c_mux_pca954x.c         | 290 +++++++++++++++++++++++++++++++
>  hw/i2c/meson.build               |   1 +
>  hw/i2c/trace-events              |   5 +
>  include/hw/i2c/i2c.h             |  17 +-
>  include/hw/i2c/i2c_mux_pca954x.h |  19 ++
>  8 files changed, 383 insertions(+), 14 deletions(-)
>  create mode 100644 hw/i2c/i2c_mux_pca954x.c
>  create mode 100644 include/hw/i2c/i2c_mux_pca954x.h
> 
> -- 
> 2.31.1.295.g9ea45b61b8-goog
> 
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]