[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-6.0?] hw/arm/armsse: Give SSE-300 its own Property array
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH for-6.0?] hw/arm/armsse: Give SSE-300 its own Property array |
|
Date: |
Thu, 15 Apr 2021 21:34:55 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 4/15/21 8:23 PM, Peter Maydell wrote:
> SSE-300 currently shares the SSE-200 Property array. This is
> bad principally because the default values of the CPU0_FPU
> and CPU0_DSP properties disable the FPU and DSP on the CPU.
> That is correct for the SSE-300 but not the SSE-200.
> Give the SSE-300 its own Property array with the correct
> SSE-300 specific settings:
> * SSE-300 has only one CPU, so no CPU1* properties
> * SSE-300 CPU has FPU and DSP
>
> Buglink: https://bugs.launchpad.net/qemu/+bug/1923861
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> This is a simple and pretty safe fix, but I don't think it quite
> merits doing an rc4 by itself. I think if we do an rc4 for some
> other reason it ought to go in, though.
Sounds good.
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>