qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 02/13] target/arm: Share unallocated_encoding() and gen_excep


From: Richard Henderson
Subject: Re: [PATCH 02/13] target/arm: Share unallocated_encoding() and gen_exception_insn()
Date: Tue, 27 Apr 2021 09:36:23 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1

On 4/13/21 9:07 AM, Peter Maydell wrote:
The unallocated_encoding() function is the same in both
translate-a64.c and translate.c; make the translate.c function global
and drop the translate-a64.c version.  To do this we need to also
share gen_exception_insn(), which currently exists in two slightly
different versions for A32 and A64: merge those into a single
function that can work for both.

This will be useful for splitting up translate.c, which will require
unallocated_encoding() to no longer be file-local.  It's also
hopefully less confusing to have only one version of the function
rather than two.

Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
---
  target/arm/translate-a64.h |  2 --
  target/arm/translate.h     |  3 +++
  target/arm/translate-a64.c | 15 ---------------
  target/arm/translate.c     | 14 +++++++++-----
  4 files changed, 12 insertions(+), 22 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]