[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [kvm-unit-tests PATCH v1 1/4] arm64: split its-trigger test into KVM
From: |
Auger Eric |
Subject: |
Re: [kvm-unit-tests PATCH v1 1/4] arm64: split its-trigger test into KVM and TCG variants |
Date: |
Wed, 28 Apr 2021 17:26:26 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 |
Hi,
On 4/28/21 4:36 PM, Marc Zyngier wrote:
> On Wed, 28 Apr 2021 15:00:15 +0100,
> Alexandru Elisei <alexandru.elisei@arm.com> wrote:
>>
>> I interpret that as that an INVALL guarantees that a change is
>> visible, but it the change can become visible even without the
>> INVALL.
>
> Yes. Expecting the LPI to be delivered or not in the absence of an
> invalidate when its configuration has been altered is wrong. The
> architecture doesn't guarantee anything of the sort.
>
>> The test relies on the fact that changes to the LPI tables are not
>> visible *under KVM* until the INVALL command, but that's not
>> necessarily the case on real hardware. To match the spec, I think
>> the test "dev2/eventid=20 still does not trigger any LPI" should be
>> removed and the stats reset should take place before the
>> configuration for LPI 8195 is set to the default.
Yes I do agree with Alexandru and Marc after another reading of the
spec. I initially thought the INVALL was the gate keeper for the new
config but that sounds wrong. This test shall be removed then.
Eric
>
> If that's what the test expects (I haven't tried to investigate), it
> should be dropped completely, rather than trying to sidestep it for
> TCG.
>
> Thanks,
>
> M.
>
- [kvm-unit-tests PATCH v1 0/4] enable LPI and ITS for TCG, Alex Bennée, 2021/04/28
- [kvm-unit-tests PATCH v1 2/4] scripts/arch-run: don't use deprecated server/nowait options, Alex Bennée, 2021/04/28
- [kvm-unit-tests PATCH v1 3/4] arm64: enable its-migration tests for TCG, Alex Bennée, 2021/04/28
- [kvm-unit-tests PATCH v1 1/4] arm64: split its-trigger test into KVM and TCG variants, Alex Bennée, 2021/04/28
- Re: [kvm-unit-tests PATCH v1 1/4] arm64: split its-trigger test into KVM and TCG variants, Marc Zyngier, 2021/04/28
- Re: [kvm-unit-tests PATCH v1 1/4] arm64: split its-trigger test into KVM and TCG variants, Alex Bennée, 2021/04/28
- Re: [kvm-unit-tests PATCH v1 1/4] arm64: split its-trigger test into KVM and TCG variants, Alexandru Elisei, 2021/04/28
- Re: [kvm-unit-tests PATCH v1 1/4] arm64: split its-trigger test into KVM and TCG variants, Marc Zyngier, 2021/04/28
- Re: [kvm-unit-tests PATCH v1 1/4] arm64: split its-trigger test into KVM and TCG variants,
Auger Eric <=
- Re: [kvm-unit-tests PATCH v1 1/4] arm64: split its-trigger test into KVM and TCG variants, Alex Bennée, 2021/04/28
- Re: [kvm-unit-tests PATCH v1 1/4] arm64: split its-trigger test into KVM and TCG variants, Alex Bennée, 2021/04/28
- Re: [kvm-unit-tests PATCH v1 1/4] arm64: split its-trigger test into KVM and TCG variants, Marc Zyngier, 2021/04/28
[kvm-unit-tests PATCH v1 4/4] arm64: split its-migrate-unmapped-collection into KVM and TCG variants, Alex Bennée, 2021/04/28