[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 1/6] virtio-gpu: no point of checking res->iov
From: |
Gerd Hoffmann |
Subject: |
[PULL 1/6] virtio-gpu: no point of checking res->iov |
Date: |
Wed, 1 Sep 2021 06:18:58 +0200 |
From: Dongwon Kim <dongwon.kim@intel.com>
The code should check the opposite condition of res->iov because it will be null
if virtio_gpu_create_mapping_iov fails and actually this checking is not even
required because checking on ret covers all failing cases.
Signed-off-by: Dongwon Kim <dongwon.kim@intel.com>
Message-Id: <20210830175033.29233-1-dongwon.kim@intel.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/display/virtio-gpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
index 990e71fd4062..72da5bf5002c 100644
--- a/hw/display/virtio-gpu.c
+++ b/hw/display/virtio-gpu.c
@@ -362,7 +362,7 @@ static void virtio_gpu_resource_create_blob(VirtIOGPU *g,
ret = virtio_gpu_create_mapping_iov(g, cblob.nr_entries, sizeof(cblob),
cmd, &res->addrs, &res->iov,
&res->iov_cnt);
- if (ret != 0 || res->iov) {
+ if (ret != 0) {
cmd->error = VIRTIO_GPU_RESP_ERR_UNSPEC;
g_free(res);
return;
--
2.31.1
- [PULL 0/6] Vga 20210901 patches, Gerd Hoffmann, 2021/09/01
- [PULL 1/6] virtio-gpu: no point of checking res->iov,
Gerd Hoffmann <=
- [PULL 2/6] hw/display: Restrict virtio-gpu-udmabuf stubs to !Linux, Gerd Hoffmann, 2021/09/01
- [PULL 3/6] ui/console: Restrict udmabuf_fd() to Linux, Gerd Hoffmann, 2021/09/01
- [PULL 5/6] hw/display/xlnx_dp: fix an out-of-bounds read in xlnx_dp_read, Gerd Hoffmann, 2021/09/01
- [PULL 4/6] vga: don't abort when adding a duplicate isa-vga device, Gerd Hoffmann, 2021/09/01
- [PULL 6/6] hw/display/artist: Fix bug in coordinate extraction in artist_vram_read() and artist_vram_write(), Gerd Hoffmann, 2021/09/01
- Re: [PULL 0/6] Vga 20210901 patches, Peter Maydell, 2021/09/01