Re: [PATCH v7 10/10] tests/data/acpi/virt: Update IORT files for ITS

[Peter Maydell]

On Wed, 1 Sept 2021 at 10:02, Igor Mammedov <imammedo@redhat.com> wrote:
>
> On Wed, 1 Sep 2021 09:06:41 +0100
> Peter Maydell <peter.maydell@linaro.org> wrote:
>
> > On Wed, 1 Sept 2021 at 09:03, Igor Mammedov <imammedo@redhat.com> wrote:
> > >
> > > not directly related to the patch but while I was testing IORT testcase
> > > (https://github.com/imammedo/qemu acpi-tests)
> > > after rebase to 6.1, I get test failure due to change in MADT table vs
> > > expected blobs made in 6.0 time and it does look like ABI change
> > > (what is bad, it also happens to virt-6.0 machine type).
> > > Can ARM folks check if we didn't break something?
> >
> > >  [02Ch 0044   1]                Subtable Type : 0C [Generic Interrupt 
> > > Distributor]
> > >  [02Dh 0045   1]                       Length : 18
> > >  [02Eh 0046   2]                     Reserved : 0000
> > >  [030h 0048   4]        Local GIC Hardware ID : 00000000
> > >  [034h 0052   8]                 Base Address : 0000000008000000
> > >  [03Ch 0060   4]               Interrupt Base : 00000000
> > > -[040h 0064   1]                      Version : 02
> > > +[040h 0064   1]                      Version : 03
> >
> > This says the GIC changed from GICv2 to v3. What QEMU command line are
> For the test case, I'm more interested in if the rest of numbers are correct 
> for defaut virt machine type.
>
> But in case of virt-6.0 we might have problem.
>
> > you using here ?
>
> -machine virt -accel kvm -accel tcg -nodefaults -nographic -drive 
> if=pflash,format=raw,file=pc-bios/edk2-aarch64-code.fd,readonly=on -drive 
> if=pflash,format=raw,file=pc-bios/edk2-arm-vars.fd,snapshot=on -cdrom 
> tests/data/uefi-boot-images/bios-tables-test.aarch64.iso.qcow2 -cpu host 
> -machine virt-6.0
>                                                                               
>     ^^^^^^^^

With KVM enabled you get "whatever interrupt controller the host has",
so the configuration is not stable across different host machines. So this
is not a usable setup to generate or cross-check the ACPI test blobs.
(It should get you the same configuration across QEMU versions but on
the same host machine, though.)

(All the diffs you quote are interrupt-controller related in one way
or another.)

-- PMM