[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 5/5] hw/char: cadence_uart: Ignore access when unclocked o
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v2 5/5] hw/char: cadence_uart: Ignore access when unclocked or in reset for uart_{read, write}() |
|
Date: |
Thu, 2 Sep 2021 08:11:21 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 9/2/21 8:09 AM, Philippe Mathieu-Daudé wrote:
> On 9/1/21 5:27 AM, Bin Meng wrote:
>> Read or write to uart registers when unclocked or in reset should be
>> ignored. Add the check there, and as a result of this, the check in
>> uart_write_tx_fifo() is now unnecessary.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>>
>> ---
>>
>> Changes in v2:
>> - new patch: hw/char: cadence_uart: Ignore access when unclocked or in reset
>> for uart_{read,write}()
>>
>> hw/char/cadence_uart.c | 15 ++++++++++-----
>> 1 file changed, 10 insertions(+), 5 deletions(-)
>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Just realized it is simpler to implement MemoryRegionOps::accepts().