[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 26/28] target/ppc: Replace g_memdup() by g_memdup2()
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v3 26/28] target/ppc: Replace g_memdup() by g_memdup2() |
Date: |
Fri, 3 Sep 2021 19:45:08 +0200 |
Per
https://discourse.gnome.org/t/port-your-module-from-g-memdup-to-g-memdup2-now/5538
The old API took the size of the memory to duplicate as a guint,
whereas most memory functions take memory sizes as a gsize. This
made it easy to accidentally pass a gsize to g_memdup(). For large
values, that would lead to a silent truncation of the size from 64
to 32 bits, and result in a heap area being returned which is
significantly smaller than what the caller expects. This can likely
be exploited in various modules to cause a heap buffer overflow.
Replace g_memdup() by the safer g_memdup2() wrapper.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
target/ppc/mmu-hash64.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/ppc/mmu-hash64.c b/target/ppc/mmu-hash64.c
index 19832c4b46f..bc6f8748acb 100644
--- a/target/ppc/mmu-hash64.c
+++ b/target/ppc/mmu-hash64.c
@@ -1122,7 +1122,7 @@ void ppc_hash64_init(PowerPCCPU *cpu)
return;
}
- cpu->hash64_opts = g_memdup(pcc->hash64_opts, sizeof(*cpu->hash64_opts));
+ cpu->hash64_opts = g_memdup2(pcc->hash64_opts, sizeof(*cpu->hash64_opts));
}
void ppc_hash64_finalize(PowerPCCPU *cpu)
--
2.31.1
- [PATCH v3 17/28] hw/rdma: Replace g_memdup() by g_memdup2(), (continued)
- [PATCH v3 17/28] hw/rdma: Replace g_memdup() by g_memdup2(), Philippe Mathieu-Daudé, 2021/09/03
- [PATCH v3 18/28] hw/vfio/pci: Replace g_memdup() by g_memdup2(), Philippe Mathieu-Daudé, 2021/09/03
- [RFC PATCH v3 19/28] hw/virtio: Replace g_memdup() by g_memdup2(), Philippe Mathieu-Daudé, 2021/09/03
- [PATCH v3 20/28] net/colo: Replace g_memdup() by g_memdup2(), Philippe Mathieu-Daudé, 2021/09/03
- [RFC PATCH v3 21/28] ui/clipboard: Replace g_memdup() by g_memdup2(), Philippe Mathieu-Daudé, 2021/09/03
- [RFC PATCH v3 22/28] linux-user: Replace g_memdup() by g_memdup2(), Philippe Mathieu-Daudé, 2021/09/03
- [PATCH v3 23/28] tests/unit: Replace g_memdup() by g_memdup2(), Philippe Mathieu-Daudé, 2021/09/03
- [PATCH v3 24/28] tests/qtest: Replace g_memdup() by g_memdup2(), Philippe Mathieu-Daudé, 2021/09/03
- [PATCH v3 25/28] target/arm: Replace g_memdup() by g_memdup2(), Philippe Mathieu-Daudé, 2021/09/03
- [PATCH v3 26/28] target/ppc: Replace g_memdup() by g_memdup2(),
Philippe Mathieu-Daudé <=
- [PATCH v3 27/28] contrib: Replace g_memdup() by g_memdup2(), Philippe Mathieu-Daudé, 2021/09/03
- [PATCH v3 28/28] checkpatch: Do not allow deprecated g_memdup(), Philippe Mathieu-Daudé, 2021/09/03