Re: [PATCH 04/10] aspeed/smc: Drop AspeedSMCController structure

[Philippe Mathieu-Daudé]

On 9/7/21 8:58 AM, Cédric Le Goater wrote:
> The characteristics of the Aspeed controllers are described in a
> AspeedSMCController structure which is redundant with the
> AspeedSMCClass. Move all attributes under the class and adapt the code
> to use class attributes instead.
> 
> This is a large change but it is functionally equivalent.
> 
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
>  include/hw/ssi/aspeed_smc.h |  64 ++-
>  hw/arm/aspeed_ast2600.c     |   4 +-
>  hw/arm/aspeed_soc.c         |   4 +-
>  hw/ssi/aspeed_smc.c         | 859 ++++++++++++++++++++----------------
>  4 files changed, 510 insertions(+), 421 deletions(-)

Overall LGTM, I might do a more detailed pass later.