qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v9 01/11] arm: Move PMC register definitions to cpu.h


From: Peter Maydell
Subject: Re: [PATCH v9 01/11] arm: Move PMC register definitions to cpu.h
Date: Mon, 13 Sep 2021 09:49:39 +0100

On Mon, 13 Sept 2021 at 00:07, Alexander Graf <agraf@csgraf.de> wrote:
>
> We will need PMC register definitions in accel specific code later.
> Move all constant definitions to common arm headers so we can reuse
> them.
>
> Signed-off-by: Alexander Graf <agraf@csgraf.de>
> ---
>  target/arm/cpu.h    | 44 ++++++++++++++++++++++++++++++++++++++++++++
>  target/arm/helper.c | 44 --------------------------------------------
>  2 files changed, 44 insertions(+), 44 deletions(-)

Do these need to be in cpu.h, or would target/arm/internals.h
be good enough? (Lots of files all over the codebase include
cpu.h, so if the only users of these defines and functions are
in target/arm, internals.h is better.)

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]