[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type
From: |
Joel Stanley |
Subject: |
Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type |
Date: |
Tue, 14 Sep 2021 12:14:28 +0000 |
On Tue, 14 Sept 2021 at 11:59, Peter Delevoryas <pdel@fb.com> wrote:
>
>
> > On Sep 14, 2021, at 3:56 AM, Cédric Le Goater <clg@kaod.org> wrote:
> >
> >
> > Hello Peter D,
> >
> >> +static void aspeed_machine_fuji_class_init(ObjectClass *oc, void *data)
> >> +{
> >> + MachineClass *mc = MACHINE_CLASS(oc);
> >> + AspeedMachineClass *amc = ASPEED_MACHINE_CLASS(oc);
> >> +
> >> + mc->desc = "Facebook Fuji BMC (Cortex-A7)";
> >> + amc->soc_name = "ast2600-a3";
> >> + amc->hw_strap1 = FUJI_BMC_HW_STRAP1;
> >> + amc->hw_strap2 = FUJI_BMC_HW_STRAP2;
> >> + amc->fmc_model = "mx66l1g45g";
> >> + amc->spi_model = "mx66l1g45g";
> >> + amc->num_cs = 2;
> >> + amc->macs_mask = ASPEED_MAC3_ON;
> >> + amc->i2c_init = fuji_bmc_i2c_init;
> >> + amc->uart_default = ASPEED_DEV_UART1;
> >> + mc->default_ram_size = 2 * GiB;
> >
> > Is that the default of the Fuji board ? This is causing an issue in our
> > tests :
> >
> > qemu-system-aarch64: at most 2047 MB RAM can be simulated
> >
> > Could we lower it down to 1G ?
>
> Yikes, sorry about that. I thought it was 2G, but yeah let’s just lower it to
> 1G. I might be completely wrong anyways.
The upstream device tree uses 2G:
https://elixir.bootlin.com/linux/v5.15-rc1/source/arch/arm/boot/dts/ast2600-facebook-netbmc-common.dtsi#L20
It's unfortunate we limit the defaults given very few (no one?) is
using this model on a machine that is 32 bit.
OTOH, modelling 1G of RAM is useful for testing, so it's no great loss.
Cheers,
Joel
- Re: [PULL 00/14] aspeed queue, (continued)
- [PULL 00/14] aspeed queue, Cédric Le Goater, 2021/09/13
- [PULL 04/14] watchdog: aspeed: Fix sequential control writes, Cédric Le Goater, 2021/09/13
- [PULL 13/14] hw/arm/aspeed: Allow machine to set UART default, Cédric Le Goater, 2021/09/13
- [PULL 07/14] misc/pca9552: Fix LED status register indexing in pca955x_get_led(), Cédric Le Goater, 2021/09/13
- [PULL 08/14] arm/aspeed: rainier: Add i2c eeproms and muxes, Cédric Le Goater, 2021/09/13
- [PULL 09/14] aspeed: Emulate the AST2600A3, Cédric Le Goater, 2021/09/13
- [PULL 14/14] hw/arm/aspeed: Add Fuji machine type, Cédric Le Goater, 2021/09/13
- Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type, Cédric Le Goater, 2021/09/14
- Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type, Peter Delevoryas, 2021/09/14
- Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type,
Joel Stanley <=
- Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type, Peter Maydell, 2021/09/14
- Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type, Richard Henderson, 2021/09/14
- Deprecate 32-bit hosts? (was: Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type), Thomas Huth, 2021/09/15
- Re: Deprecate 32-bit hosts? (was: Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type), Philippe Mathieu-Daudé, 2021/09/15
- Re: Deprecate 32-bit hosts? (was: Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type), Daniel P . Berrangé, 2021/09/15
- Re: Deprecate 32-bit hosts? (was: Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type), Philippe Mathieu-Daudé, 2021/09/15
- Re: Deprecate 32-bit hosts? (was: Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type), Daniel P . Berrangé, 2021/09/15
- Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type, Cédric Le Goater, 2021/09/16
- Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type, Philippe Mathieu-Daudé, 2021/09/16
- Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type, Cédric Le Goater, 2021/09/16