Re: [PATCH v2 07/53] target/alpha: convert to use format_state instead of dump_state

[Philippe Mathieu-Daudé]

On 9/14/21 4:19 PM, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  target/alpha/cpu.c    |  2 +-
>  target/alpha/cpu.h    |  2 +-
>  target/alpha/helper.c | 28 ++++++++++++++++------------
>  3 files changed, 18 insertions(+), 14 deletions(-)
> 
> diff --git a/target/alpha/cpu.c b/target/alpha/cpu.c
> index 4871ad0c0a..d0cdda9554 100644
> --- a/target/alpha/cpu.c
> +++ b/target/alpha/cpu.c
> @@ -239,7 +239,7 @@ static void alpha_cpu_class_init(ObjectClass *oc, void 
> *data)
>  
>      cc->class_by_name = alpha_cpu_class_by_name;
>      cc->has_work = alpha_cpu_has_work;
> -    cc->dump_state = alpha_cpu_dump_state;
> +    cc->format_state = alpha_cpu_format_state;
>      cc->set_pc = alpha_cpu_set_pc;
>      cc->gdb_read_register = alpha_cpu_gdb_read_register;
>      cc->gdb_write_register = alpha_cpu_gdb_write_register;
> diff --git a/target/alpha/cpu.h b/target/alpha/cpu.h
> index 82df108967..9e3c80ebcc 100644
> --- a/target/alpha/cpu.h
> +++ b/target/alpha/cpu.h
> @@ -278,7 +278,7 @@ extern const VMStateDescription vmstate_alpha_cpu;
>  
>  void alpha_cpu_do_interrupt(CPUState *cpu);
>  bool alpha_cpu_exec_interrupt(CPUState *cpu, int int_req);
> -void alpha_cpu_dump_state(CPUState *cs, FILE *f, int flags);
> +void alpha_cpu_format_state(CPUState *cs, GString *buf, int flags);
>  hwaddr alpha_cpu_get_phys_page_debug(CPUState *cpu, vaddr addr);
>  int alpha_cpu_gdb_read_register(CPUState *cpu, GByteArray *buf, int reg);
>  int alpha_cpu_gdb_write_register(CPUState *cpu, uint8_t *buf, int reg);
> diff --git a/target/alpha/helper.c b/target/alpha/helper.c
> index 4f56fe4d23..6ed80e8a27 100644
> --- a/target/alpha/helper.c
> +++ b/target/alpha/helper.c
> @@ -451,7 +451,7 @@ bool alpha_cpu_exec_interrupt(CPUState *cs, int 
> interrupt_request)
>      return false;
>  }
>  
> -void alpha_cpu_dump_state(CPUState *cs, FILE *f, int flags)
> +void alpha_cpu_format_state(CPUState *cs, GString *buf, int flags)
>  {

Unrelated, but this code doesn't belong to helper.c IMO, but cpu.c.

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>