[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v11 09/14] machine: Use ms instead of global current_machine
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH v11 09/14] machine: Use ms instead of global current_machine in sanity-check |
|
Date: |
Tue, 28 Sep 2021 11:21:35 +0100 |
|
User-agent: |
Mutt/2.0.7 (2021-05-04) |
On Tue, Sep 28, 2021 at 11:57:50AM +0800, Yanan Wang wrote:
> In the sanity-check of smp_cpus and max_cpus against mc in function
> machine_set_smp(), we are now using ms->smp.max_cpus for the check
> but using current_machine->smp.max_cpus in the error message.
> Tweak this by uniformly using the local ms.
>
> Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
> Reviewed-by: Andrew Jones <drjones@redhat.com>
> Reviewed-by: Pankaj Gupta <pankaj.gupta@ionos.com>
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
> ---
> hw/core/machine.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH v11 05/14] machine: Improve the error reporting of smp parsing, (continued)
- [PATCH v11 05/14] machine: Improve the error reporting of smp parsing, Yanan Wang, 2021/09/27
- [PATCH v11 06/14] qtest/numa-test: Use detailed -smp CLIs in pc_dynamic_cpu_cfg, Yanan Wang, 2021/09/27
- [PATCH v11 07/14] qtest/numa-test: Use detailed -smp CLIs in test_def_cpu_split, Yanan Wang, 2021/09/27
- [PATCH v11 09/14] machine: Use ms instead of global current_machine in sanity-check, Yanan Wang, 2021/09/27
- [PATCH v11 08/14] machine: Prefer cores over sockets in smp parsing since 6.2, Yanan Wang, 2021/09/27
- [PATCH v11 03/14] machine: Uniformly use maxcpus to calculate the omitted parameters, Yanan Wang, 2021/09/27
- [PATCH v11 10/14] machine: Tweak the order of topology members in struct CpuTopology, Yanan Wang, 2021/09/27
- [PATCH v11 11/14] machine: Make smp_parse generic enough for all arches, Yanan Wang, 2021/09/27