[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 18/26] hw/intc/arm_gicv3_its: Fix handling of process_its_cmd() r
From: |
Peter Maydell |
Subject: |
[PATCH 18/26] hw/intc/arm_gicv3_its: Fix handling of process_its_cmd() return value |
Date: |
Sat, 11 Dec 2021 19:11:27 +0000 |
process_its_cmd() returns a bool, like all the other process_ functions.
However we were putting its return value into 'res', not 'result',
which meant we would ignore it when deciding whether to continue
or stall the command queue. Fix the typo.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/intc/arm_gicv3_its.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/intc/arm_gicv3_its.c b/hw/intc/arm_gicv3_its.c
index e6b380f663c..32cf18c10af 100644
--- a/hw/intc/arm_gicv3_its.c
+++ b/hw/intc/arm_gicv3_its.c
@@ -676,10 +676,10 @@ static void process_cmdq(GICv3ITSState *s)
switch (cmd) {
case GITS_CMD_INT:
- res = process_its_cmd(s, data, cq_offset, INTERRUPT);
+ result = process_its_cmd(s, data, cq_offset, INTERRUPT);
break;
case GITS_CMD_CLEAR:
- res = process_its_cmd(s, data, cq_offset, CLEAR);
+ result = process_its_cmd(s, data, cq_offset, CLEAR);
break;
case GITS_CMD_SYNC:
/*
--
2.25.1
- Re: [PATCH 26/26] hw/intc/arm_gicv3_its: Factor out "find address of table entry" code, (continued)
- [PATCH 24/26] hw/intc/arm_gicv3_its: Fix return codes in process_mapc(), Peter Maydell, 2021/12/11
- [PATCH 25/26] hw/intc/arm_gicv3_its: Fix return codes in process_mapd(), Peter Maydell, 2021/12/11
- [PATCH 16/26] hw/intc/arm_gicv3_its: Fix event ID bounds checks, Peter Maydell, 2021/12/11
- [PATCH 18/26] hw/intc/arm_gicv3_its: Fix handling of process_its_cmd() return value,
Peter Maydell <=
- [PATCH 19/26] hw/intc/arm_gicv3_its: Don't use data if reading command failed, Peter Maydell, 2021/12/11
- [PATCH 22/26] hw/intc/arm_gicv3_its: Refactor process_its_cmd() to reduce nesting, Peter Maydell, 2021/12/11
- [PATCH 23/26] hw/intc/arm_gicv3_its: Fix return codes in process_mapti(), Peter Maydell, 2021/12/11