[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/1] hw/arm/aspeed: Add fby35 machine type
From: |
Peter Delevoryas |
Subject: |
Re: [PATCH 0/1] hw/arm/aspeed: Add fby35 machine type |
Date: |
Tue, 3 May 2022 22:47:41 +0000 |
> On May 3, 2022, at 2:35 PM, Cédric Le Goater <clg@kaod.org> wrote:
>
> On 5/3/22 22:44, Peter Delevoryas wrote:
>> Hey everyone,
>> I'm submitting another Facebook (Meta Platforms) machine type: this time I'm
>> including an acceptance test too.
>> Unfortunately, this machine boots _very_ slowly. 300+ seconds.
>
> This is too much for avocado tests.
Erg, yeah I figured as much. I’ll just resubmit it without the avocado test
then,
if that sounds ok to you.
>
>> I'm not sure why this is (so I don't know how to fix it easily)
>
> The fuji has the same kind of problem. It takes ages to load the lzma ramdisk.
> Could it be a modeling issue ? or how the FW image is compiled ?
Yeah, one reason is that Facebook OpenBMC machines have an unnecessarily
big initramfs that includes all the rootfs stuff, whereas regular OpenBMC
machines have a smaller initramfs right? I don’t entirely know what I’m talking
about though.
I think most FB machines have moved to zstd compression recently though,
but this one may have been missed: I can fix that on the image side. I’ll
also experiment more to see if it’s something wrong with the image, or possibly
a regression in QEMU. It would really be super awesome if it could boot faster,
so I’m very motivated to find a solution.
>
> Thanks,
>
> C.
>
>
>> and I don't know how to override
>> the avocado test timeout just for a single test, so I increased the global
>> timeout for all "boot_linux_console.py" tests from 90s to 400s. I doubt this
>> is
>> acceptable, but what other option is there? Should I add
>> AVOCADO_TIMEOUT_EXPECTED?
>> @skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout')
>> What is the point of this environment variable though, except to skip it in
>> CIT?
>> If I run the test with this environment variable defined, it doesn't disable
>> the
>> timeout, it just skips it right? I want an option to run this test with a
>> larger
>> timeout.
>> Thanks,
>> Peter
>> Peter Delevoryas (1):
>> hw/arm/aspeed: Add fby35 machine type
>> hw/arm/aspeed.c | 63 +++++++++++++++++++++++++++++
>> tests/avocado/boot_linux_console.py | 20 ++++++++-
>> 2 files changed, 82 insertions(+), 1 deletion(-)
>