[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 078/114] target/arm: Use TRANS_FEAT for FMMLA
From: |
Richard Henderson |
Subject: |
[PATCH 078/114] target/arm: Use TRANS_FEAT for FMMLA |
Date: |
Fri, 27 May 2022 11:18:31 -0700 |
Being able to specify the feature predicate in TRANS_FEAT
makes it easier to split trans_FMMLA by element size,
which also happens to simplify the decode.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/sve.decode | 7 +++----
target/arm/translate-sve.c | 27 ++++-----------------------
2 files changed, 7 insertions(+), 27 deletions(-)
diff --git a/target/arm/sve.decode b/target/arm/sve.decode
index 7e79198f5b..a54feb2f61 100644
--- a/target/arm/sve.decode
+++ b/target/arm/sve.decode
@@ -1598,10 +1598,9 @@ SQRDCMLAH_zzzz 01000100 esz:2 0 rm:5 0011 rot:2 rn:5
rd:5 ra=%reg_movprfx
USDOT_zzzz 01000100 .. 0 ..... 011 110 ..... ..... @rda_rn_rm
### SVE2 floating point matrix multiply accumulate
-{
- BFMMLA 01100100 01 1 ..... 111 001 ..... ..... @rda_rn_rm_e0
- FMMLA 01100100 .. 1 ..... 111 001 ..... ..... @rda_rn_rm
-}
+BFMMLA 01100100 01 1 ..... 111 001 ..... ..... @rda_rn_rm_e0
+FMMLA_s 01100100 10 1 ..... 111 001 ..... ..... @rda_rn_rm_e0
+FMMLA_d 01100100 11 1 ..... 111 001 ..... ..... @rda_rn_rm_e0
### SVE2 Memory Gather Load Group
diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c
index a799ce3110..364e419f3e 100644
--- a/target/arm/translate-sve.c
+++ b/target/arm/translate-sve.c
@@ -7318,29 +7318,10 @@ DO_SVE2_ZPZZ_FP(FMINP, fminp)
* SVE Integer Multiply-Add (unpredicated)
*/
-static bool trans_FMMLA(DisasContext *s, arg_rrrr_esz *a)
-{
- gen_helper_gvec_4_ptr *fn;
-
- switch (a->esz) {
- case MO_32:
- if (!dc_isar_feature(aa64_sve_f32mm, s)) {
- return false;
- }
- fn = gen_helper_fmmla_s;
- break;
- case MO_64:
- if (!dc_isar_feature(aa64_sve_f64mm, s)) {
- return false;
- }
- fn = gen_helper_fmmla_d;
- break;
- default:
- return false;
- }
-
- return gen_gvec_fpst_zzzz(s, fn, a->rd, a->rn, a->rm, a->ra, 0, FPST_FPCR);
-}
+TRANS_FEAT(FMMLA_s, aa64_sve_f32mm, gen_gvec_fpst_zzzz, gen_helper_fmmla_s,
+ a->rd, a->rn, a->rm, a->ra, 0, FPST_FPCR)
+TRANS_FEAT(FMMLA_d, aa64_sve_f64mm, gen_gvec_fpst_zzzz, gen_helper_fmmla_d,
+ a->rd, a->rn, a->rm, a->ra, 0, FPST_FPCR)
static gen_helper_gvec_4 * const sqdmlal_zzzw_fns[] = {
NULL, gen_helper_sve2_sqdmlal_zzzw_h,
--
2.34.1
- [PATCH 067/114] target/arm: Use TRANS_FEAT for do_sve2_ppzz_flags, (continued)
- [PATCH 067/114] target/arm: Use TRANS_FEAT for do_sve2_ppzz_flags, Richard Henderson, 2022/05/27
- [PATCH 076/114] target/arm: Use TRANS_FEAT for do_zzi_ool, Richard Henderson, 2022/05/27
- [PATCH 075/114] target/arm: Use TRANS_FEAT for do_zzi_sat, Richard Henderson, 2022/05/27
- [PATCH 056/114] target/arm: Use TRANS_FEAT for do_perm_pred2, Richard Henderson, 2022/05/27
- [PATCH 063/114] target/arm: Use TRANS_FEAT for do_last_fp, Richard Henderson, 2022/05/27
- [PATCH 062/114] target/arm: Use TRANS_FEAT for do_clast_general, Richard Henderson, 2022/05/27
- [PATCH 060/114] target/arm: Use TRANS_FEAT for do_clast_vector, Richard Henderson, 2022/05/27
- [PATCH 058/114] target/arm: Use gen_gvec_ool_arg_zzz for do_zip, do_zip_q, Richard Henderson, 2022/05/27
- [PATCH 066/114] target/arm: Use TRANS_FEAT for do_ppzz_flags, Richard Henderson, 2022/05/27
- [PATCH 065/114] target/arm: Use TRANS_FEAT for SPLICE, Richard Henderson, 2022/05/27
- [PATCH 078/114] target/arm: Use TRANS_FEAT for FMMLA,
Richard Henderson <=
- [PATCH 069/114] target/arm: Use TRANS_FEAT for do_brk2, do_brk3, Richard Henderson, 2022/05/27
- [PATCH 070/114] target/arm: Use TRANS_FEAT for MUL_zzi, Richard Henderson, 2022/05/27
- [PATCH 071/114] target/arm: Reject dup_i w/ shifted byte early, Richard Henderson, 2022/05/27
- [PATCH 079/114] target/arm: Move sve check into gen_gvec_fn_ppp, Richard Henderson, 2022/05/27
- [PATCH 073/114] target/arm: Reject copy w/ shifted byte early, Richard Henderson, 2022/05/27
- [PATCH 083/114] target/arm: Use TRANS_FEAT for FMLA, Richard Henderson, 2022/05/27
- [PATCH 080/114] target/arm: Implement NOT (prediates) alias, Richard Henderson, 2022/05/27
- [PATCH 085/114] target/arm: Rename do_zzz_fp to gen_gvec_ool_fpst_arg_zzz, Richard Henderson, 2022/05/27
- [PATCH 081/114] target/arm: Use TRANS_FEAT for SEL_zpzz, Richard Henderson, 2022/05/27
- [PATCH 082/114] target/arm: Use TRANS_FEAT for MOVPRFX, Richard Henderson, 2022/05/27