[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH-for-9.0 v2 10/19] hw/xen: Rename 'ram_memory' global variable
|
From: |
David Woodhouse |
|
Subject: |
Re: [PATCH-for-9.0 v2 10/19] hw/xen: Rename 'ram_memory' global variable as 'xen_memory' |
|
Date: |
Tue, 14 Nov 2023 10:49:07 -0500 |
|
User-agent: |
K-9 Mail for Android |
On 14 November 2023 09:38:06 GMT-05:00, "Philippe Mathieu-Daudé"
<philmd@linaro.org> wrote:
>To avoid a potential global variable shadow in
>hw/i386/pc_piix.c::pc_init1(), rename Xen's
>"ram_memory" as "xen_memory".
>
>Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Well OK, but aren't you going to be coming back later to eliminate global
variables which are actually per-VM?
Or is that the point, because *then* the conflicting name will actually matter?
Reviewed-by: David Woodhouse <dwmw@amazon.co.uk>
[PATCH-for-9.0 v2 07/19] hw/xen: Remove unnecessary xen_hvm_inject_msi() stub, Philippe Mathieu-Daudé, 2023/11/14
[PATCH-for-9.0 v2 08/19] hw/xen: Remove unused Xen stubs, Philippe Mathieu-Daudé, 2023/11/14
[RFC PATCH-for-9.0 v2 09/19] hw/block/xen_blkif: Align structs with QEMU_ALIGNED() instead of #pragma, Philippe Mathieu-Daudé, 2023/11/14
[PATCH-for-9.0 v2 10/19] hw/xen: Rename 'ram_memory' global variable as 'xen_memory', Philippe Mathieu-Daudé, 2023/11/14
- Re: [PATCH-for-9.0 v2 10/19] hw/xen: Rename 'ram_memory' global variable as 'xen_memory',
David Woodhouse <=
[PATCH-for-9.0 v2 11/19] hw/xen/xen_arch_hvm: Rename prototypes using 'xen_arch_' prefix, Philippe Mathieu-Daudé, 2023/11/14
[PATCH-for-9.0 v2 15/19] hw/xen: Reduce inclusion of 'cpu.h' to target-specific sources, Philippe Mathieu-Daudé, 2023/11/14
[PATCH-for-9.0 v2 12/19] hw/xen: Merge 'hw/xen/arch_hvm.h' in 'hw/xen/xen-hvm-common.h', Philippe Mathieu-Daudé, 2023/11/14
[RFC PATCH-for-9.0 v2 13/19] hw/xen: Remove use of 'target_ulong' in handle_ioreq(), Philippe Mathieu-Daudé, 2023/11/14
[PATCH-for-9.0 v2 14/19] hw/xen: Use target-agnostic qemu_target_page_bits(), Philippe Mathieu-Daudé, 2023/11/14
[PATCH-for-9.0 v2 16/19] hw/xen/xen_pt: Add missing license, Philippe Mathieu-Daudé, 2023/11/14
[PATCH-for-9.0 v2 17/19] hw/xen: Extract 'xen_igd.h' from 'xen_pt.h', Philippe Mathieu-Daudé, 2023/11/14
[PATCH-for-9.0 v2 18/19] hw/i386/xen: Compile 'xen-hvm.c' with Xen CPPFLAGS, Philippe Mathieu-Daudé, 2023/11/14