Re: [PATCH 08/14] blockjob: return status from block_job_set

qemu-block

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 08/14] blockjob: return status from block_job_set_speed()

From:	Alberto Garcia
Subject:	Re: [PATCH 08/14] blockjob: return status from block_job_set_speed()
Date:	Thu, 17 Sep 2020 16:01:26 +0200
User-agent:	Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu)

On Wed 09 Sep 2020 08:59:24 PM CEST, Vladimir Sementsov-Ogievskiy wrote:
> Better to return status together with setting errp. It allows to avoid
> error propagation in the caller.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

Reviewed-by: Alberto Garcia <berto@igalia.com>

Berto

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH 11/14] block/qcow2-bitmap: return startus from qcow2_store_persistent_dirty_bitmaps, (continued)
- [PATCH 06/14] block/mirror: drop extra error propagation in commit_active_start(), Vladimir Sementsov-Ogievskiy, 2020/09/09
  - Re: [PATCH 06/14] block/mirror: drop extra error propagation in commit_active_start(), Greg Kurz, 2020/09/10
  - Re: [PATCH 06/14] block/mirror: drop extra error propagation in commit_active_start(), Alberto Garcia, 2020/09/17
- [PATCH 08/14] blockjob: return status from block_job_set_speed(), Vladimir Sementsov-Ogievskiy, 2020/09/09
  - Re: [PATCH 08/14] blockjob: return status from block_job_set_speed(), Greg Kurz, 2020/09/11
  - Re: [PATCH 08/14] blockjob: return status from block_job_set_speed(), Alberto Garcia <=
- [PATCH 12/14] block/qcow2: read_cache_sizes: return status value, Vladimir Sementsov-Ogievskiy, 2020/09/09
  - Re: [PATCH 12/14] block/qcow2: read_cache_sizes: return status value, Greg Kurz, 2020/09/11
  - Re: [PATCH 12/14] block/qcow2: read_cache_sizes: return status value, Alberto Garcia, 2020/09/17
- [PATCH 09/14] block/qcow2: qcow2_get_specific_info(): drop error propagation, Vladimir Sementsov-Ogievskiy, 2020/09/09
  - Re: [PATCH 09/14] block/qcow2: qcow2_get_specific_info(): drop error propagation, Greg Kurz, 2020/09/11
  - Re: [PATCH 09/14] block/qcow2: qcow2_get_specific_info(): drop error propagation, Alberto Garcia, 2020/09/17
    - Re: [PATCH 09/14] block/qcow2: qcow2_get_specific_info(): drop error propagation, Vladimir Sementsov-Ogievskiy, 2020/09/17
- [PATCH 13/14] block/qcow2: qcow2_do_open: deal with errp, Vladimir Sementsov-Ogievskiy, 2020/09/09
  - Re: [PATCH 13/14] block/qcow2: qcow2_do_open: deal with errp, Alberto Garcia, 2020/09/17
    - Re: [PATCH 13/14] block/qcow2: qcow2_do_open: deal with errp, Vladimir Sementsov-Ogievskiy, 2020/09/17

Prev by Date: Re: [PATCH 02/14] block: use return status of bdrv_append()
Next by Date: Re: [PATCH 1/3] block/block-backend: add converter from BlockAcctStats to BlockBackend
Previous by thread: Re: [PATCH 08/14] blockjob: return status from block_job_set_speed()
Next by thread: [PATCH 12/14] block/qcow2: read_cache_sizes: return status value
Index(es):
- Date
- Thread