Re: [PATCH v2 12/13] block/qcow2: simplify qcow2_co_invalidate

qemu-block

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 12/13] block/qcow2: simplify qcow2_co_invalidate_cache()

From:	Alberto Garcia
Subject:	Re: [PATCH v2 12/13] block/qcow2: simplify qcow2_co_invalidate_cache()
Date:	Fri, 18 Sep 2020 17:26:05 +0200
User-agent:	Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu)

On Thu 17 Sep 2020 09:55:18 PM CEST, Vladimir Sementsov-Ogievskiy wrote:
> qcow2_do_open correctly sets errp on each failure path. So, we can
> simplify code in qcow2_co_invalidate_cache() and drop explicit error
> propagation. We should use ERRP_GUARD() (accordingly to comment in
> include/qapi/error.h) together with error_append() call which we add to
> avoid problems with error_fatal.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

Reviewed-by: Alberto Garcia <berto@igalia.com>

Berto

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v2 02/13] block: use return status of bdrv_append(), (continued)
- [PATCH v2 02/13] block: use return status of bdrv_append(), Vladimir Sementsov-Ogievskiy, 2020/09/17
- [PATCH v2 04/13] blockdev: fix drive_backup_prepare() missed error, Vladimir Sementsov-Ogievskiy, 2020/09/17
- [PATCH v2 05/13] block: drop extra error propagation for bdrv_set_backing_hd, Vladimir Sementsov-Ogievskiy, 2020/09/17
- [PATCH v2 03/13] block: check return value of bdrv_open_child and drop error propagation, Vladimir Sementsov-Ogievskiy, 2020/09/17
- [PATCH v2 10/13] block/qcow2-bitmap: return status from qcow2_store_persistent_dirty_bitmaps, Vladimir Sementsov-Ogievskiy, 2020/09/17
  - Re: [PATCH v2 10/13] block/qcow2-bitmap: return status from qcow2_store_persistent_dirty_bitmaps, Alberto Garcia, 2020/09/18
- [PATCH v2 06/13] block/mirror: drop extra error propagation in commit_active_start(), Vladimir Sementsov-Ogievskiy, 2020/09/17
- [PATCH v2 07/13] blockjob: return status from block_job_set_speed(), Vladimir Sementsov-Ogievskiy, 2020/09/17
- [PATCH v2 11/13] block/qcow2: read_cache_sizes: return status value, Vladimir Sementsov-Ogievskiy, 2020/09/17
- [PATCH v2 12/13] block/qcow2: simplify qcow2_co_invalidate_cache(), Vladimir Sementsov-Ogievskiy, 2020/09/17
  - Re: [PATCH v2 12/13] block/qcow2: simplify qcow2_co_invalidate_cache(), Alberto Garcia <=
  - Re: [PATCH v2 12/13] block/qcow2: simplify qcow2_co_invalidate_cache(), Greg Kurz, 2020/09/18
    - Re: [PATCH v2 12/13] block/qcow2: simplify qcow2_co_invalidate_cache(), Alberto Garcia, 2020/09/18
    - Re: [PATCH v2 12/13] block/qcow2: simplify qcow2_co_invalidate_cache(), Vladimir Sementsov-Ogievskiy, 2020/09/18
    - Re: [PATCH v2 12/13] block/qcow2: simplify qcow2_co_invalidate_cache(), Greg Kurz, 2020/09/18
- [PATCH v2 08/13] block/qcow2: qcow2_get_specific_info(): drop error propagation, Vladimir Sementsov-Ogievskiy, 2020/09/17
  - Re: [PATCH v2 08/13] block/qcow2: qcow2_get_specific_info(): drop error propagation, Alberto Garcia, 2020/09/18
- [PATCH v2 09/13] block/qcow2-bitmap: improve qcow2_load_dirty_bitmaps() interface, Vladimir Sementsov-Ogievskiy, 2020/09/17
  - Re: [PATCH v2 09/13] block/qcow2-bitmap: improve qcow2_load_dirty_bitmaps() interface, Alberto Garcia, 2020/09/18
    - Re: [PATCH v2 09/13] block/qcow2-bitmap: improve qcow2_load_dirty_bitmaps() interface, Vladimir Sementsov-Ogievskiy, 2020/09/18
  - Re: [PATCH v2 09/13] block/qcow2-bitmap: improve qcow2_load_dirty_bitmaps() interface, Greg Kurz, 2020/09/18

Prev by Date: Re: [PATCH v2 10/13] block/qcow2-bitmap: return status from qcow2_store_persistent_dirty_bitmaps
Next by Date: Re: [PATCH v2 12/13] block/qcow2: simplify qcow2_co_invalidate_cache()
Previous by thread: [PATCH v2 12/13] block/qcow2: simplify qcow2_co_invalidate_cache()
Next by thread: Re: [PATCH v2 12/13] block/qcow2: simplify qcow2_co_invalidate_cache()
Index(es):
- Date
- Thread