[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] tests/check-block: Do not run the iotests with old versio
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v2] tests/check-block: Do not run the iotests with old versions of bash |
Date: |
Fri, 18 Sep 2020 16:48:05 +0100 |
User-agent: |
Mutt/1.14.6 (2020-07-11) |
On Fri, Sep 18, 2020 at 05:35:14PM +0200, Thomas Huth wrote:
> macOS is shipped with a very old version of the bash (3.2), which
> is currently not suitable for running the iotests anymore (e.g.
> it is missing support for "readarray" which is used in the file
> tests/qemu-iotests/common.filter). Add a check to skip the iotests
> in this case - if someone still wants to run the iotests on macOS,
> they can install a newer version from homebrew, for example.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> v2: Use LANG=C and "-q"
>
> tests/check-block.sh | 5 +++++
> 1 file changed, 5 insertions(+)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|