[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] file-posix: Correctly read max_segments of SG nodes
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH 1/2] file-posix: Correctly read max_segments of SG nodes |
|
Date: |
Sat, 19 Sep 2020 17:18:08 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 17/09/20 18:44, Dmitry Fomichev wrote:
>
> Maxim, looks like you are on top of this problem and your approach sounds
> sensible too me. Just FYI, it is also possible to avoid using
> SG_GET_SG_TABLESIZE
> ioctl and rely entirely on sysfs, but the code gets a bit more complicated
> (see below)
I would prefer to have the code in block/ but I have no problem if the
hardware limits are placed in a new field of bs->bl. Then scsi-block
and scsi-generic can consult it instead of bs->bl.max_transfer.
Paolo