[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 01/17] hw/block/nvme: fix typo in trace event
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v2 01/17] hw/block/nvme: fix typo in trace event |
Date: |
Mon, 21 Sep 2020 17:49:13 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 9/18/20 10:36 PM, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
>
> Fix a typo in the sq doorbell trace event.
>
> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> ---
> hw/block/trace-events | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/block/trace-events b/hw/block/trace-events
> index ec94c56a4165..8ff4cbc4932c 100644
> --- a/hw/block/trace-events
> +++ b/hw/block/trace-events
> @@ -70,7 +70,7 @@ pci_nvme_enqueue_req_completion(uint16_t cid, uint16_t
> cqid, uint16_t status) "c
> pci_nvme_mmio_read(uint64_t addr) "addr 0x%"PRIx64""
> pci_nvme_mmio_write(uint64_t addr, uint64_t data) "addr 0x%"PRIx64" data
> 0x%"PRIx64""
> pci_nvme_mmio_doorbell_cq(uint16_t cqid, uint16_t new_head) "cqid %"PRIu16"
> new_head %"PRIu16""
> -pci_nvme_mmio_doorbell_sq(uint16_t sqid, uint16_t new_tail) "cqid %"PRIu16"
> new_tail %"PRIu16""
> +pci_nvme_mmio_doorbell_sq(uint16_t sqid, uint16_t new_tail) "sqid %"PRIu16"
> new_tail %"PRIu16""
Oops.
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> pci_nvme_mmio_intm_set(uint64_t data, uint64_t new_mask) "wrote MMIO,
> interrupt mask set, data=0x%"PRIx64", new_mask=0x%"PRIx64""
> pci_nvme_mmio_intm_clr(uint64_t data, uint64_t new_mask) "wrote MMIO,
> interrupt mask clr, data=0x%"PRIx64", new_mask=0x%"PRIx64""
> pci_nvme_mmio_cfg(uint64_t data) "wrote MMIO, config controller
> config=0x%"PRIx64""
>
- [PATCH v2 00/17] hw/block/nvme: multiple namespaces support, Klaus Jensen, 2020/09/18
- [PATCH v2 01/17] hw/block/nvme: fix typo in trace event, Klaus Jensen, 2020/09/18
- Re: [PATCH v2 01/17] hw/block/nvme: fix typo in trace event,
Philippe Mathieu-Daudé <=
- [PATCH v2 04/17] hw/block/nvme: commonize nvme_rw error handling, Klaus Jensen, 2020/09/18
- [PATCH v2 02/17] pci: pass along the return value of dma_memory_rw, Klaus Jensen, 2020/09/18
- [PATCH v2 05/17] hw/block/nvme: alignment style fixes, Klaus Jensen, 2020/09/18
- [PATCH v2 03/17] hw/block/nvme: handle dma errors, Klaus Jensen, 2020/09/18
- [PATCH v2 06/17] hw/block/nvme: add a lba to bytes helper, Klaus Jensen, 2020/09/18
- [PATCH v2 07/17] hw/block/nvme: fix endian conversion, Klaus Jensen, 2020/09/18
- [PATCH v2 08/17] hw/block/nvme: add symbolic command name to trace events, Klaus Jensen, 2020/09/18