[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH for-6.0 v2 5/8] hw/block/nvme: fix warning about legacy namespace
From: |
Klaus Jensen |
Subject: |
[PATCH for-6.0 v2 5/8] hw/block/nvme: fix warning about legacy namespace configuration |
Date: |
Mon, 5 Apr 2021 19:54:49 +0200 |
From: Klaus Jensen <k.jensen@samsung.com>
Remove the unused BlockConf from the controller structure and fix the
constraint checking to actually check the right BlockConf and issue the
warning.
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
Reviewed-by: Gollu Appalanaidu <anaidu.gollu@samsung.com>
---
hw/block/nvme.h | 1 -
hw/block/nvme.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/block/nvme.h b/hw/block/nvme.h
index c610ab30dc5c..1570f65989a7 100644
--- a/hw/block/nvme.h
+++ b/hw/block/nvme.h
@@ -166,7 +166,6 @@ typedef struct NvmeCtrl {
NvmeBar bar;
NvmeParams params;
NvmeBus bus;
- BlockConf conf;
uint16_t cntlid;
bool qs_created;
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 6d31d5b17a0b..de0e726dfdd8 100644
--- a/hw/block/nvme.c
+++ b/hw/block/nvme.c
@@ -5813,7 +5813,7 @@ static void nvme_check_constraints(NvmeCtrl *n, Error
**errp)
params->max_ioqpairs = params->num_queues - 1;
}
- if (n->conf.blk) {
+ if (n->namespace.blkconf.blk) {
warn_report("drive property is deprecated; "
"please use an nvme-ns device instead");
}
--
2.31.1
[PATCH for-6.0 v2 8/8] hw/block/nvme: add missing copyright headers, Klaus Jensen, 2021/04/05
[PATCH for-6.0 v2 7/8] hw/block/nvme: fix handling of private namespaces, Klaus Jensen, 2021/04/05
Re: [PATCH for-6.0 v2 0/8] hw/block/nvme: misc fixes, Keith Busch, 2021/04/05