Re: [PATCH 0/2] block/rbd: fix memory leaks

[Stefano Garzarella]

On Wed, Apr 07, 2021 at 11:38:17AM +0200, Markus Armbruster wrote:
> Max Reitz <mreitz@redhat.com> writes:
>
> > On 29.03.21 17:01, Stefano Garzarella wrote:
> > > This series fixes two memory leaks, found through valgrind, in the
> > > rbd driver.
> > > Stefano Garzarella (2):
> > >    block/rbd: fix memory leak in qemu_rbd_connect()
> > >    block/rbd: fix memory leak in qemu_rbd_co_create_opts()
> > >   block/rbd.c | 10 ++++++----
> > >   1 file changed, 6 insertions(+), 4 deletions(-)
> >
> > Reviewed-by: Max Reitz <mreitz@redhat.com>
> >
> > I’m not quite sure whether this is fit for 6.0...  I think it’s too
> > late for rc2, so I don’t know.
>
> This the maintainers' call to make.
>
> * PATCH 1:
>
>  CON: Old bug, probably 2.9, i.e. four years
>
>  PRO: The fix is straightforward
>
> * PATCH 2:
>
>  NEUTRAL: Not recent from upstream's point of view (5.0), but
>  downstreams may have different ideas
>
>  PRO: The fix is trivial
>
> I encourage you to take at least PATCH 2.

Kevin queued them up, thank you both for the review,
Stefano