Re: [PATCH] docs: add nvme emulation documentation

[Klaus Jensen]

On Apr  8 12:17, Philippe Mathieu-Daudé wrote:
> On 4/8/21 11:50 AM, Klaus Jensen wrote:
> > From: Klaus Jensen <k.jensen@samsung.com>
> >
> > Remove the docs/specs/nvme.txt and replace it with proper documentation
> > in docs/system/nvme.rst.
> >
> > Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> > ---
> >  docs/specs/nvme.txt   |  23 -----
> >  docs/system/index.rst |   1 +
> >  docs/system/nvme.rst  | 212 ++++++++++++++++++++++++++++++++++++++++++
> >  MAINTAINERS           |   2 +-
> >  4 files changed, 214 insertions(+), 24 deletions(-)
> >  delete mode 100644 docs/specs/nvme.txt
> >  create mode 100644 docs/system/nvme.rst
>
> > +Simple Copy
> > +-----------
> > +
> > +The device includes support for TP 4065 ("Simple Copy Command"). Copy command
> > +limits may be set with the ``mssrl``, ``mcl`` and ``msrc=UINT8`` ``nvme-ns``
> > +device parameters.
>
> All parameters are described except mssrl/mcl/msrc.
> Any particular reason?

Not really, missed them. I'll add them :)

> Otherwise:
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Thanks!

signature.asc
Description: PGP signature